Were we setting the user agent string in the convenience layer before? If so, are we now ending up with duplicates?

You are right. This would lead to duplicate of azsdk-js-container-registry/1.0.0-beta.4. In convenience layer we already append library info to options.userAgentOptions.userAgentPrefix.

@sarangan12 what are your thoughts? Update code gen to not append packageDetails when userAgentPrefix is passed via options, or update convenice layer to not append library info?

We were thinking of convenience layer not appending library info. From the very beginning this was one of the things that we felt could be generated. Now that we are generating, we should make use of that :)

The only thing that should be added as a prefix to this is what the user provides

Makes sense. I will update the convenience layer.

Found a bug in the codegen: my code is creating two generated clients using the same options. However, as the generated code mutates my option object, I end up having duplicate library info. I fixed it by making an updated copy of the options bag.

-    options.userAgentOptions = {
-      userAgentPrefix: userAgentPrefix
-    };
-
     const optionsWithDefaults = {
       ...defaults,
       ...options,
+      userAgentOptions: {
+        userAgentPrefix
+      },
       baseUri: options.endpoint || "{url}"
     };

Logged Azure/autorest.typescript#1039

@jeremymeng do you remember why having the const part here?

@deyaaeldeen
Because this metadata is named "prefix" and the line

const packageDetails =azsdk-js-container-registry/1.0.0-beta.4;

contains const packageDetails at the beginning. However it doesn't have to be here, if packageDetails alone also works when the bot is bumping versions.